Skip to content

feat: implement the new oCIS sharing UI - #4936

Merged
joragua merged 3 commits into
masterfrom
feature/sharing_ng_preliminary
Jul 23, 2026
Merged

feat: implement the new oCIS sharing UI#4936
joragua merged 3 commits into
masterfrom
feature/sharing_ng_preliminary

Conversation

@joragua

@joragua joragua commented Jul 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Related Issues

App: #4839

  • Add changelog files for the fixed issues in folder changelog/unreleased. More info here
  • Add feature to Release Notes in ReleaseNotesViewModel.kt creating a new ReleaseNote() with String resources (if required)

QA

@joragua joragua self-assigned this Jul 22, 2026
@joragua
joragua force-pushed the feature/sharing_ng_preliminary branch from 4079cab to 128d357 Compare July 22, 2026 10:11
@joragua joragua changed the title feat: display the new UI for OCIS sharing feat: implement the new OCIS sharing UI Jul 22, 2026
@joragua joragua linked an issue Jul 22, 2026 that may be closed by this pull request
[FEATURE REQUEST] Sharing NG: preliminary #4839
Closed
10 tasks
@joragua
joragua force-pushed the feature/sharing_ng_preliminary branch from 128d357 to 5637e8a Compare July 22, 2026 10:13
joragua added 3 commits July 22, 2026 12:49
@joragua
feat: implement the new oCIS sharing UI
0d35c00 
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
feat: allow sharing files in spaces
c42eeed 
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
chore: add calens file
695049b 
Signed-off-by: Jorge Aguado Recio <jaguado@izertis.com>
@joragua
joragua force-pushed the feature/sharing_ng_preliminary branch from c5956b9 to 695049b Compare July 22, 2026 10:50
@joragua
joragua marked this pull request as ready for review July 22, 2026 11:00
@joragua
joragua requested a review from a team as a code owner July 22, 2026 11:00
@joragua joragua changed the title feat: implement the new OCIS sharing UI feat: implement the new oCIS sharing UI Jul 22, 2026
jesmrec
jesmrec requested changes Jul 22, 2026
View reviewed changes

@jesmrec jesmrec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of changes @joragua

Comment thread owncloudApp/src/main/java/com/owncloud/android/presentation/capabilities/CapabilityViewModel.kt
Comment thread owncloudApp/src/main/java/com/owncloud/android/presentation/sharing/ShareActivity.kt
@joragua
joragua requested a review from jesmrec July 22, 2026 12:04
jesmrec
jesmrec approved these changes Jul 22, 2026
View reviewed changes

@jesmrec jesmrec left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR Approved, moving to QA

@jesmrec

jesmrec commented Jul 23, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Just a consideration: In this PR, the restriction of sharing for items inside custom spaces has been removed, so it depends on the item permission to show or hide the Share option.

That collides with the idea that the permalink is always available, and it is inside of Share menu. A user could not be allowed to share, and it'd lose the access to the permalink.

So, the Share option should be always available and other permissions will rule the sharing options.

@jesmrec

jesmrec commented Jul 23, 2026

Copy link
Copy Markdown
Member

Just a consideration: In this PR, the restriction of sharing for items inside custom spaces has been removed, so it depends on the item permission to show or hide the Share option.
That collides with the idea that the permalink is always available, and it is inside of Share menu. A user could not be allowed to share, and it'd lose the access to the permalink.
So, the Share option should be always available and other permissions will rule the sharing options.

This research is deeper as expected, so, it will be addressed to other issue/moment.

Approved on my side

@joragua
joragua merged commit 33c4ada into master Jul 23, 2026
11 checks passed
@joragua
joragua deleted the feature/sharing_ng_preliminary branch July 23, 2026 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@jesmrec jesmrec jesmrec approved these changes

Assignees

@joragua joragua

Labels

Approved by qa

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[FEATURE REQUEST] Sharing NG: preliminary

2 participants

@joragua @jesmrec